Repository navigation
RDKEMW-27767:[Develop]Intermittent Tune Failure During Linear Channel… - #312
Merged
Merged
Conversation
… Playback After Standby/Wakeup Reason for change: RPC transport errors to retryable SecManager and reuse established DRM sessions Test Procedure: None Risks: Low Priority: P0 Signed-off-by:mkooda197@cable.comcast.com
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The guard discards SecManager error contexts when InvokeJSONRPC returns false for service failures, incorrectly triggering connection retries and losing the original reason and businessStatus.
1 open issue
What changed in this PR
This PR addresses intermittent tuning failures after standby/wakeup by improving license-request retries in the Thunder and Firebolt content-security integrations.
Changes:
- Map transport failures to retryable SecManager errors.
- Reuse established DRM sessions for subsequent retries.
- Reset Firebolt transport errors per attempt and catch session-ID conversion exceptions.
| File | Description |
|---|---|
externals/contentsecuritymanager/SecManagerThunder.cpp |
Adds connection-failure retry handling and switches established sessions to update requests. |
externals/contentsecuritymanager/IFirebolt/ContentProtectionFirebolt.cpp |
Adds transport-error mapping, session reuse, per-attempt error reset, and session-ID exception handling. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Playback After Standby/Wakeup
Reason for change: RPC transport errors to retryable SecManager and reuse established DRM sessions
Test Procedure: None
Risks: Low
Priority: P0
Signed-off-by:mkooda197@cable.comcast.com